Bluetooth: Define connection event prepare callbacks #16099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc-required
rugeGerritsen
force-pushed
the
enhanced-radio-notification
branch
from
1a53d5b
to
8c5a2d6
Compare
rugeGerritsen
changed the title
rugeGerritsen
force-pushed
the
enhanced-radio-notification
branch
from
8c5a2d6
to
8d4a4f3
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
seko-nordic
reviewed
Jun 21, 2024
|
Other suggestion: Add the possibility to trigger a callback at the start of the events. Then it might make sense to define the callback as a struct so that it is possible to later add struct bt_conn_evt_cb {
void (*prepare)(struct bt_conn *conn, void *user_data);
void (*start)((struct bt_conn *conn, void *user_data);
void (*end)((struct bt_conn *conn, void *user_data);
},
int bt_conn_evt_cb_register(const struct bt_conn *conn, struct bt_conn_evt_cb cb,
void *user_data,
uint32_t prepare_distance_us); |
Tschet1
reviewed
Jun 27, 2024
rugeGerritsen
force-pushed
the
enhanced-radio-notification
branch
3 times, most recently
from
dd25a10
to
fc161a1
Compare
Tschet1
reviewed
Jul 4, 2024
rugeGerritsen
force-pushed
the
enhanced-radio-notification
branch
2 times, most recently
from
8c72532
to
1c492c7
Compare
rugeGerritsen
requested review from
alwa-nordic,
jori-nordic,
carlescufi and
KAGA164
as code owners
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
peknis
requested changes
Jul 10, 2024
rugeGerritsen
force-pushed
the
enhanced-radio-notification
branch
from
1c492c7
to
a92d993
Compare
alwa-nordic
previously requested changes
Jul 10, 2024
peknis
approved these changes
Jul 11, 2024
rugeGerritsen
force-pushed
the
enhanced-radio-notification
branch
from
a92d993
to
e96b93b
Compare
seko-nordic
reviewed
Jul 12, 2024
seko-nordic
reviewed
Jul 12, 2024
seko-nordic
reviewed
Jul 12, 2024
| - nrf52dk/nrf52832 | ||
| - nrf52840dk/nrf52840 | ||
| - nrf5340dk/nrf5340/cpunet | ||
| platform_allow: nrf52dk/nrf52832 nrf52840dk/nrf52840 nrf5340dk/nrf5340/cpunet |
There was a problem hiding this comment.
Not yet. Need to add EGU definitions here: https://github.com/zephyrproject-rtos/zephyr/blob/main/modules/hal_nordic/nrfx/Kconfig#L64. I believe we can do that separately to unblock other work
There was a problem hiding this comment.
Will be possible after zephyrproject-rtos/zephyr#75866 is in NCS
seko-nordic
reviewed
Jul 12, 2024
KAGA164
suggested changes
Jul 12, 2024
rugeGerritsen
force-pushed
the
enhanced-radio-notification
branch
3 times, most recently
from
4ecc58a
to
0e71b11
Compare
Tschet1
reviewed
Jul 15, 2024
| The device may wake up more often if, for example, it has data to send. | ||
| The central device assumes that the peripheral will wake up at every connection event. | ||
|
|
||
| The :c:member:`ble_radio_notification_conn_cb.prepare` callback will be called before every connection event for both the peripheral and central device. |
There was a problem hiding this comment.
Should we combine this with the previous paragraph? I think they logically belong together.
rugeGerritsen
force-pushed
the
enhanced-radio-notification
branch
from
0e71b11
to
f6b8ff6
Compare
Tschet1
reviewed
Jul 15, 2024
Tschet1
reviewed
Jul 15, 2024
Tschet1
approved these changes
Jul 15, 2024
The Radio Notification callback feature replaces the radio notification feature. It can be used to synchronize data sampling with Bluetooth connection events. The old feature had several weaknesses: - It was not possible to know which connection the notification belonged to. - The trigger also happened upon flash access. - The time from trigger until event start was fixed. That is, not configurable per use case. The new feature is built on top of the connection event trigger feature and is therefore able to known which connection a given notification belongs to. The feature is marked as experimental. Currently this feature will cancels out peripheral latency which we indent to change. Signed-off-by: Rubin Gerritsen <[email protected]>
The sample demonstrates how the Radio Notification connection callback feature can used to minimize latency between data sampling and on air transmission. Signed-off-by: Rubin Gerritsen <[email protected]>
rugeGerritsen
force-pushed
the
enhanced-radio-notification
branch
from
f6b8ff6
to
04ec46d
Compare
KAGA164
approved these changes
Jul 17, 2024
rugeGerritsen
dismissed
alwa-nordic’s stale review
Dismissing Aleksanders' review. The changes pushed later were pairprogrammed with him
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection event callback feature replaces
the radio notification feature. It can be used to
synchronize data sampling with Bluetooth connection events.
The old feature had several weaknesses:
the notification belonged to.
That is, not configurable per use case.
The new feature is built on top of the connection event
trigger feature and is therefore able to known
which connection a given notification belongs to.
This PR is done on top of #15798 to simplify the implementation